Fix desktop menu docs links regression by benceruleanlu · Pull Request #7181 · Comfy-Org/ComfyUI_frontend

benceruleanlu · 2025-12-05T06:16:09Z

Summary

make useExternalLink rely on the global i18n locale so it can be used safely outside setup
restore electronAdapter to use the shared useExternalLink helper for docs URLs and static links

Motivation

Desktop menu items disappeared because a top-level call to useExternalLink in electronAdapter triggered useI18n at module-eval time, throwing and blocking extension registration. By making the composable global-locale-only and using it in electronAdapter, the module can load without setup context while preserving link behavior.

Testing

pnpm typecheck
pnpm lint:fix

┆Issue is synchronized with this Notion page by Unito

github-actions · 2025-12-05T06:16:28Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/05/2025, 10:30:46 PM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

coderabbitai · 2025-12-05T06:16:29Z

📝 Walkthrough

Walkthrough

useExternalLink now sources locale from the global i18n instance (i18n.global.locale.value, wrapped in a computed) instead of the useI18n() composable; tests were updated to provide a minimal @/i18n mock and to read/mutate i18n.global.locale.value.

Changes

Cohort / File(s)	Summary
I18n access refactor `src/composables/useExternalLink.ts`	Replaced `useI18n().locale` with a computed derived from `i18n.global.locale.value`; `isChinese` still computed from the locale. No changes to exported signatures.
Test i18n mock update `tests-ui/tests/composables/useExternalLink.test.ts`, `@/i18n`	Tests no longer mock `useI18n()`; they provide a minimal `@/i18n` export and set `i18n.global.locale.value` before importing the composable. Test locale mutations now modify `i18n.global.locale.value`. No API changes.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/desktop-menu-check-update

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd794d7 and 54f9e76.

📒 Files selected for processing (1)

tests-ui/tests/composables/useExternalLink.test.ts (6 hunks)

🧰 Additional context used

📓 Path-based instructions (10)

**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursorrules)

Use es-toolkit for utility functions

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

Use TypeScript for type safety

**/*.{ts,tsx}: Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
Use defaultsByInstallVersion property for gradual feature rollout based on version in settings configuration

Files:

tests-ui/tests/composables/useExternalLink.test.ts

tests-ui/**/*.test.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (tests-ui/CLAUDE.md)

tests-ui/**/*.test.{js,ts,jsx,tsx}: Write tests for new features
Follow existing test patterns in the codebase
Use existing test utilities rather than writing custom utilities
Mock external dependencies in tests
Always prefer vitest mock functions over writing verbose manual mocks

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/*.{test,spec}.{ts,tsx,js}

📄 CodeRabbit inference engine (AGENTS.md)

Unit and component tests should be located in tests-ui/ or co-located with components as src/components/**/*.{test,spec}.ts; E2E tests should be in browser_tests/

Files:

tests-ui/tests/composables/useExternalLink.test.ts

**/composables/use*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name composables in the format useXyz.ts

Files:

tests-ui/tests/composables/useExternalLink.test.ts

🧠 Learnings (18)

📓 Common learnings

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Mock external dependencies in tests

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/locales/en/main.json:2257-2272
Timestamp: 2025-12-05T20:35:28.309Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, vue-i18n pluralization uses a two-parameter pattern: `t('key', { count: value })` where the `count` property in the interpolation object automatically triggers plural selection from pipe-separated locale strings (e.g., "no items | 1 item | {count} items"). This is the correct pattern used throughout the codebase, as validated by Playwright tests.

📚 Learning: 2025-11-24T19:46:52.279Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.{vue,ts,tsx} : Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Mock external dependencies in tests

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Use existing test utilities rather than writing custom utilities

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Always prefer vitest mock functions over writing verbose manual mocks

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:46:52.279Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.{vue,ts,tsx} : Leverage VueUse functions for performance-enhancing utilities

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Write tests for new features

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:23.088Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T19:48:23.088Z
Learning: Applies to **/*.{ts,tsx,vue} : Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:23.088Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T19:48:23.088Z
Learning: Use Vitest (with happy-dom) for unit and component tests, and Playwright for E2E tests

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:09.318Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Use `vitest` for unit testing in this project

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:09.318Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Use `test` instead of `it` for defining test cases in vitest

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:09.318Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Prefer the use of `test.extend` over loose variables; import `test as baseTest` from `vitest`

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:09.318Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Mocks should be cleanly written and easy to understand, with reusable mocks where possible

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

📚 Learning: 2025-11-24T19:48:09.318Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Tests should be cross-platform compatible using `path.resolve`, `path.join`, and `path.sep` for Windows, macOS, and Linux compatibility

Applied to files:

tests-ui/tests/composables/useExternalLink.test.ts

🧬 Code graph analysis (1)

tests-ui/tests/composables/useExternalLink.test.ts (1)

src/composables/useExternalLink.ts (1)

useExternalLink (25-99)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: test
GitHub Check: setup
GitHub Check: lint-and-format
GitHub Check: collect

🔇 Additional comments (1)

tests-ui/tests/composables/useExternalLink.test.ts (1)

29-29: LGTM! Consistent locale mutation pattern.

All test cases consistently mutate i18n.global.locale.value to control locale behavior, and the beforeEach hook properly resets the locale to 'en' for test isolation. This aligns well with the composable's new approach of reading from the global i18n instance.

Also applies to: 58-58, 66-66, 74-74, 82-82, 97-97, 109-109, 121-121, 138-138

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-05T06:16:32Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/05/2025, 10:39:47 PM UTC

📈 Summary

Total Tests: 494
Passed: 480 ✅
Failed: 0
Flaky: 4 ⚠️
Skipped: 10 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 471 / ❌ 0 / ⚠️ 4 / ⏭️ 10
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copilot

Pull request overview

This PR fixes a desktop menu regression where docs links disappeared due to useExternalLink being called at module-eval time in electronAdapter. The fix makes the composable safe to use outside Vue setup context by accessing the global i18n locale directly instead of using the composition API's useI18n().

Replaced useI18n() call with direct access to i18n.global.locale in useExternalLink composable
Updated test mocks to align with the new implementation approach

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`src/composables/useExternalLink.ts`	Changed to use `i18n.global.locale` instead of `useI18n()` to enable usage outside setup context
`tests-ui/tests/composables/useExternalLink.test.ts`	Updated mock to mock `@/i18n` module instead of `vue-i18n` to match new implementation

github-actions · 2025-12-05T06:18:46Z

Bundle Size Report

Summary

Raw size: 17 MB baseline 17 MB — 🔴 +35 B
Gzip: 3.38 MB baseline 3.38 MB — 🟢 -77 B
Brotli: 2.59 MB baseline 2.59 MB — 🟢 -294 B
Bundles: 97 current • 97 baseline • 37 added / 37 removed

Category Glance
App Entry Points 🔴 +35 B (3.2 MB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.81 MB) · Graph Workspace ⚪ 0 B (975 kB) · Panels & Settings ⚪ 0 B (298 kB) · UI Components ⚪ 0 B (173 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.2 MB (baseline 3.2 MB) • 🔴 +35 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-C6zY353T.js (new)	—	2.97 MB	🔴 +2.97 MB	🔴 +619 kB	🔴 +470 kB
~~assets/index-NcN2yNbL.js~~ (removed)	2.97 MB	—	🟢 -2.97 MB	🟢 -619 kB	🟢 -470 kB
~~assets/index-B5TFmRGo.js~~ (removed)	223 kB	—	🟢 -223 kB	🟢 -47.6 kB	🟢 -39.2 kB
assets/index-DZNLMUio.js (new)	—	223 kB	🔴 +223 kB	🔴 +47.6 kB	🔴 +39.3 kB
assets/index-BEgPYscs.js (new)	—	345 B	🔴 +345 B	🔴 +246 B	🔴 +233 B
~~assets/index-DgCUcViE.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -245 B	🟢 -209 B

Status: 3 added / 3 removed

Graph Workspace — 975 kB (baseline 975 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/GraphView-Br01p4F1.js~~ (removed)	975 kB	—	🟢 -975 kB	🟢 -188 kB	🟢 -144 kB
assets/GraphView-V8r9CnyV.js (new)	—	975 kB	🔴 +975 kB	🔴 +188 kB	🔴 +144 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-56rdlZCO.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.9 kB
~~assets/UserSelectView-DvnKBPIe.js~~ (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/CreditsPanel-BYiT6kFM.js~~ (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.15 kB	🟢 -4.5 kB
assets/CreditsPanel-Csxymx9P.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.15 kB	🔴 +4.5 kB
~~assets/KeybindingPanel-BV9GgzLK.js~~ (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.02 kB
assets/KeybindingPanel-Cal0kB1L.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.02 kB
~~assets/ExtensionPanel-88GuN0s5.js~~ (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.57 kB	🟢 -2.26 kB
assets/ExtensionPanel-mOvoMmdK.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.26 kB
~~assets/AboutPanel-DCAgq5IH.js~~ (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.21 kB
assets/AboutPanel-qdxGGI1x.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.21 kB
assets/ServerConfigPanel-C9lyGycO.js (new)	—	6.56 kB	🔴 +6.56 kB	🔴 +1.83 kB	🔴 +1.63 kB
~~assets/ServerConfigPanel-gQAK0QSe.js~~ (removed)	6.56 kB	—	🟢 -6.56 kB	🟢 -1.83 kB	🟢 -1.63 kB
assets/UserPanel-B7L2JtPj.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.72 kB	🔴 +1.51 kB
~~assets/UserPanel-CCQmIPD5.js~~ (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.72 kB	🟢 -1.51 kB
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BXTtSH4O.js	33.3 kB	33.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C9Pzn-NG.js	25.2 kB	25.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CCy2fA_h.js	27.3 kB	27.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CQpqEFfl.js	26.6 kB	26.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DHcnxypw.js	21.7 kB	21.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DhFTK9fY.js	25.1 kB	25.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DlT4t_ui.js	25.9 kB	25.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DRgSrIdD.js	24.2 kB	24.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-tjkeqiZq.js	21.1 kB	21.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 173 kB (baseline 173 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-Cx2D5Jgs.js (new)	—	53.9 kB	🔴 +53.9 kB	🔴 +8.52 kB	🔴 +7.32 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-DgVX7fMB.js~~ (removed)	53.9 kB	—	🟢 -53.9 kB	🟢 -8.52 kB	🟢 -7.31 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-C8Pth5_T.js~~ (removed)	47.6 kB	—	🟢 -47.6 kB	🟢 -10.3 kB	🟢 -8.91 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DeOS4jAn.js (new)	—	47.6 kB	🔴 +47.6 kB	🔴 +10.3 kB	🔴 +8.91 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-DfBKdg7Z.js~~ (removed)	43.8 kB	—	🟢 -43.8 kB	🟢 -9.78 kB	🟢 -8.55 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-ToUPxrjr.js (new)	—	43.8 kB	🔴 +43.8 kB	🔴 +9.78 kB	🔴 +8.55 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-CqBMwBL6.js~~ (removed)	12.9 kB	—	🟢 -12.9 kB	🟢 -3.37 kB	🟢 -2.97 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DvLqI_ki.js (new)	—	12.9 kB	🔴 +12.9 kB	🔴 +3.37 kB	🔴 +2.96 kB
assets/ComfyQueueButton-BTpyW7vu.js (new)	—	8.44 kB	🔴 +8.44 kB	🔴 +2.47 kB	🔴 +2.21 kB
~~assets/ComfyQueueButton-C5sdjdsx.js~~ (removed)	8.44 kB	—	🟢 -8.44 kB	🟢 -2.47 kB	🟢 -2.21 kB
assets/MediaTitle.vue_vue_type_script_setup_true_lang-8NCx4lLH.js (new)	—	897 B	🔴 +897 B	🔴 +505 B	🔴 +434 B
~~assets/MediaTitle.vue_vue_type_script_setup_true_lang-CWlyjxWa.js~~ (removed)	897 B	—	🟢 -897 B	🟢 -502 B	🟢 -438 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-CDkUGVOA.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-CbZj9xHx.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-Bb3LZ5y7.js	2.26 kB	2.26 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-B9q01lOl.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.84 kB	🔴 +1.57 kB
~~assets/keybindingService-rqVf4MZT.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.58 kB
assets/audioService-BokyzyuM.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +961 B	🔴 +824 B
~~assets/audioService-Dsxikl7j.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -959 B	🟢 -823 B
assets/serverConfigStore-uprby_D3.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/audioUtils-3v1kZv2o.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -650 B	🟢 -548 B
assets/audioUtils-B24Juh7_.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +654 B	🔴 +547 B
assets/mathUtil-CTARWQ-l.js	1.07 kB	1.07 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js	460 B	460 B	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-BhMrpT7H.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-Djvsb6Yg.js	3.98 MB	3.98 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-vP_q3PtU.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-aR6ntw5X.js	1.37 MB	1.37 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-abEQAgz5.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-abso1wrr.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BZLod3g9.js	407 kB	407 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/WidgetRecordAudio-C7k8e85O.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.24 kB	🔴 +4.62 kB
~~assets/WidgetRecordAudio-JR4YLpnt.js~~ (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.24 kB	🟢 -4.63 kB
assets/AudioPreviewPlayer-BRi0YEC-.js (new)	—	13.5 kB	🔴 +13.5 kB	🔴 +3.4 kB	🔴 +3.04 kB
~~assets/AudioPreviewPlayer-DgWjFM6H.js~~ (removed)	13.5 kB	—	🟢 -13.5 kB	🟢 -3.4 kB	🟢 -3.04 kB
assets/WidgetGalleria-BwnsEgtU.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.44 kB	🔴 +1.3 kB
~~assets/WidgetGalleria-lJbh3b_Z.js~~ (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.44 kB	🟢 -1.3 kB
assets/WidgetColorPicker-1Hn_tn9j.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
~~assets/WidgetColorPicker-C_qlcs3g.js~~ (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
~~assets/WidgetMarkdown-C_XIPmze.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.13 kB
assets/WidgetMarkdown-DQj50N4G.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.12 kB
~~assets/WidgetTextarea-BvKbDqLy.js~~ (removed)	2.93 kB	—	🟢 -2.93 kB	🟢 -1.17 kB	🟢 -1.04 kB
assets/WidgetTextarea-DBXo97Es.js (new)	—	2.93 kB	🔴 +2.93 kB	🔴 +1.17 kB	🔴 +1.03 kB
~~assets/WidgetAudioUI--Vb8T7Lq.js~~ (removed)	2.85 kB	—	🟢 -2.85 kB	🟢 -1.17 kB	🟢 -1.05 kB
assets/WidgetAudioUI-CV8MSI6u.js (new)	—	2.85 kB	🔴 +2.85 kB	🔴 +1.17 kB	🔴 +1.05 kB
~~assets/WidgetInputText-BHJtesqN.js~~ (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -917 B	🟢 -847 B
assets/WidgetInputText-BJzqhayK.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +918 B	🔴 +843 B
assets/MediaImageBottom-CFgDY6oP.js (new)	—	1.57 kB	🔴 +1.57 kB	🔴 +743 B	🔴 +647 B
~~assets/MediaImageBottom-i4XU57IH.js~~ (removed)	1.57 kB	—	🟢 -1.57 kB	🟢 -743 B	🟢 -646 B
~~assets/MediaAudioBottom-Dm22bsA_.js~~ (removed)	1.52 kB	—	🟢 -1.52 kB	🟢 -739 B	🟢 -656 B
assets/MediaAudioBottom-ORPe5eWh.js (new)	—	1.52 kB	🔴 +1.52 kB	🔴 +741 B	🔴 +664 B
assets/MediaVideoBottom-BUeIsDFR.js (new)	—	1.52 kB	🔴 +1.52 kB	🔴 +741 B	🔴 +656 B
~~assets/MediaVideoBottom-C6wKYU97.js~~ (removed)	1.52 kB	—	🟢 -1.52 kB	🟢 -740 B	🟢 -659 B
assets/Media3DBottom-A6VtycRv.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +732 B	🔴 +650 B
~~assets/Media3DBottom-D7LnTn9_.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -731 B	🟢 -652 B
~~assets/Media3DTop-CjflNSph.js~~ (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -761 B	🟢 -651 B
assets/Media3DTop-CYxNECRJ.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +764 B	🔴 +648 B
~~assets/WidgetSelect-DdQmg5VV.js~~ (removed)	655 B	—	🟢 -655 B	🟢 -343 B	🟢 -310 B
assets/WidgetSelect-q8AkDn7n.js (new)	—	655 B	🔴 +655 B	🔴 +342 B	🔴 +290 B
assets/WidgetInputNumber-CDVJthSk.js (new)	—	595 B	🔴 +595 B	🔴 +330 B	🔴 +277 B
~~assets/WidgetInputNumber-CeEl4eFG.js~~ (removed)	595 B	—	🟢 -595 B	🟢 -329 B	🟢 -277 B
~~assets/Load3D-CFSYIT7u.js~~ (removed)	424 B	—	🟢 -424 B	🟢 -269 B	🟢 -225 B
assets/Load3D-DuSERX4c.js (new)	—	424 B	🔴 +424 B	🔴 +267 B	🔴 +224 B
assets/WidgetLegacy-Bn2GesK4.js (new)	—	364 B	🔴 +364 B	🔴 +237 B	🔴 +194 B
~~assets/WidgetLegacy-D_NY7s2n.js~~ (removed)	364 B	—	🟢 -364 B	🟢 -236 B	🟢 -193 B
assets/commands-_s-RvhJR.js	13.6 kB	13.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BuUILW6P.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BV4R6fLx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CLwPdnT6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CWMchBmd.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DazTQhtc.js	12.9 kB	12.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DmWrOe93.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwiH7Kr6.js	13.8 kB	13.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-mS3LCNPn.js	14.5 kB	14.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B1JflQcI.js	72.2 kB	72.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B2lyXe48.js	114 kB	114 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B9XEQ-pc.js	94 kB	94 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BErKFzc-.js	73.1 kB	73.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Bf7Tze-u.js	83.4 kB	83.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BhGMcO4Q.js	84.3 kB	84.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CPZUloNQ.js	99 kB	99 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dva0z-T2.js	86.5 kB	86.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-un0K9wDS.js	81.8 kB	81.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-DCIZ2mdC.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-Du4uz2Wm.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-59yKN05c.js	2.76 kB	2.76 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-8e6QYQW0.js	283 kB	283 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-A_9dx4yn.js	304 kB	304 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BbD3HDi7.js	307 kB	307 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BOJhIPft.js	369 kB	369 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-C-Pw33mW.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-ChLyG0UJ.js	285 kB	285 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CUVPxA4l.js	342 kB	342 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dx5Y4xrW.js	310 kB	310 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JqO5mNmW.js	306 kB	306 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-Beblk1io.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-CMMfeF2r.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetToggleSwitch-C8WLR8XC.js	1.58 kB	1.58 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 17 added / 17 removed

DrJKL · 2025-12-05T09:18:14Z

tests-ui/tests/composables/useExternalLink.test.ts

-  useI18n: vi.fn(() => ({
-    locale: mockLocale
-  }))
+vi.mock('@/i18n', () => ({


You should be able to just createI18n as a plugin for the test

actually this sounds somewhat excessive, we only need i18n.global.locale.value, can you recheck? idm either way eod though

https://github.com/search?q=repo%3AComfy-Org%2FComfyUI_frontend+path%3A.test.ts+createI18n({&type=code

simula-r

LGTM

## Summary - make `useExternalLink` rely on the global i18n locale so it can be used safely outside setup - restore `electronAdapter` to use the shared `useExternalLink` helper for docs URLs and static links ## Motivation Desktop menu items disappeared because a top-level call to `useExternalLink` in `electronAdapter` triggered `useI18n` at module-eval time, throwing and blocking extension registration. By making the composable global-locale-only and using it in `electronAdapter`, the module can load without setup context while preserving link behavior. ## Testing - pnpm typecheck - pnpm lint:fix ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7181-Fix-desktop-menu-docs-links-regression-2c06d73d36508157ae48cff078b9173e) by [Unito](https://www.unito.io)

comfy-pr-bot · 2025-12-09T05:20:33Z

@benceruleanlu Successfully backported to #7278

Backport of #7181 to `core/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7278-backport-core-1-33-Fix-desktop-menu-docs-links-regression-2c46d73d36508115ab76e36fa53cd5d8) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>

## Summary - make `useExternalLink` rely on the global i18n locale so it can be used safely outside setup - restore `electronAdapter` to use the shared `useExternalLink` helper for docs URLs and static links ## Motivation Desktop menu items disappeared because a top-level call to `useExternalLink` in `electronAdapter` triggered `useI18n` at module-eval time, throwing and blocking extension registration. By making the composable global-locale-only and using it in `electronAdapter`, the module can load without setup context while preserving link behavior. ## Testing - pnpm typecheck - pnpm lint:fix ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7181-Fix-desktop-menu-docs-links-regression-2c06d73d36508157ae48cff078b9173e) by [Unito](https://www.unito.io) (cherry picked from commit 41eb457)

## Summary - make `useExternalLink` rely on the global i18n locale so it can be used safely outside setup - restore `electronAdapter` to use the shared `useExternalLink` helper for docs URLs and static links ## Motivation Desktop menu items disappeared because a top-level call to `useExternalLink` in `electronAdapter` triggered `useI18n` at module-eval time, throwing and blocking extension registration. By making the composable global-locale-only and using it in `electronAdapter`, the module can load without setup context while preserving link behavior. ## Testing - pnpm typecheck - pnpm lint:fix ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7181-Fix-desktop-menu-docs-links-regression-2c06d73d36508157ae48cff078b9173e) by [Unito](https://www.unito.io)

comfy-pr-bot · 2025-12-15T18:21:34Z

@benceruleanlu Successfully backported to #7501

Backport of #7181 to `core/1.34` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7501-backport-core-1-34-Fix-desktop-menu-docs-links-regression-2ca6d73d365081bc8785ecc142e9c729) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>

## Summary - make `useExternalLink` rely on the global i18n locale so it can be used safely outside setup - restore `electronAdapter` to use the shared `useExternalLink` helper for docs URLs and static links ## Motivation Desktop menu items disappeared because a top-level call to `useExternalLink` in `electronAdapter` triggered `useI18n` at module-eval time, throwing and blocking extension registration. By making the composable global-locale-only and using it in `electronAdapter`, the module can load without setup context while preserving link behavior. ## Testing - pnpm typecheck - pnpm lint:fix ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7181-Fix-desktop-menu-docs-links-regression-2c06d73d36508157ae48cff078b9173e) by [Unito](https://www.unito.io)

benceruleanlu added 3 commits December 4, 2025 22:09

Fix electron adapter docs link builder

89b9af8

Use global i18n in useExternalLink

4689f55

Use shared useExternalLink in electron adapter

0b1e496

Copilot AI review requested due to automatic review settings December 5, 2025 06:16

benceruleanlu requested a review from a team as a code owner December 5, 2025 06:16

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 5, 2025

Copilot started reviewing on behalf of benceruleanlu December 5, 2025 06:16 View session

Copilot finished reviewing on behalf of benceruleanlu December 5, 2025 06:18

Copilot AI reviewed Dec 5, 2025

View reviewed changes

DrJKL reviewed Dec 5, 2025

View reviewed changes

benceruleanlu added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.32 core/1.33 labels Dec 5, 2025

Fix test issue

bd794d7

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 5, 2025

Switch to mocking i18n.global.locale.value

54f9e76

benceruleanlu requested a review from DrJKL December 5, 2025 22:34

benceruleanlu added core/1.33 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.32 core/1.33 labels Dec 9, 2025

simula-r approved these changes Dec 9, 2025

View reviewed changes

christian-byrne approved these changes Dec 9, 2025

View reviewed changes

christian-byrne merged commit 41eb457 into main Dec 9, 2025
37 checks passed

christian-byrne deleted the fix/desktop-menu-check-update branch December 9, 2025 05:20

comfy-pr-bot mentioned this pull request Dec 9, 2025

[backport core/1.33] Fix desktop menu docs links regression #7278

Merged

github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Dec 9, 2025

christian-byrne mentioned this pull request Dec 9, 2025

I appreciate you all, but PLEASE STOP FIXING WHAT ISN'T BROKEN #7219

Closed

christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.34 and removed core/1.33 labels Dec 15, 2025

comfy-pr-bot mentioned this pull request Dec 15, 2025

[backport core/1.34] Fix desktop menu docs links regression #7501

Merged

github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Dec 15, 2025

Conversation

benceruleanlu commented Dec 5, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Testing

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

coderabbitai bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

DrJKL Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

benceruleanlu Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

benceruleanlu Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

DrJKL Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

simula-r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

comfy-pr-bot commented Dec 9, 2025

Uh oh!

comfy-pr-bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benceruleanlu commented Dec 5, 2025 •

edited by sync-by-unito bot

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

coderabbitai bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading